Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45229 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssh-f board as a variant ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45229/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45229/3//COMMIT_MSG@11 PS3, Line 11: (though no output for it) If the integrated graphics device is unusable, I'd disable it. If it can be used for compute tasks, then I'd mention that it's enabled for this reason so that no one disables it again.
https://review.coreboot.org/c/coreboot/+/45229/3/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md:
https://review.coreboot.org/c/coreboot/+/45229/3/Documentation/mainboard/sup... PS3, Line 37: - S3 resume not working I think this is because of FSP-M and SPS firmware. SPS firmware doesn't support CpuReplacementCheck, so FSP-M always does a full memory training.
https://review.coreboot.org/c/coreboot/+/45229/3/Documentation/mainboard/sup... PS3, Line 39: - The IGD has an invalid state on coreboot and failed to be initialize by Linux kernel I'd disable it then.
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 73: smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthShort" "CPU SLOT6 PCI-E 3.0 X8(IN X16)" "SlotDataBusWidth8X" I'd break these SMBIOS lines in two