Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44817 )
Change subject: util/ifdtool: Fix miscellaneous IFD offset since Gen 5 PCH
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44817/2/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44817/2/util/ifdtool/ifdtool.c@802
PS2, Line 802: if (is_platform_with_100x_series_pch())
: printf(" PSL: 0x%02x\n", (fdb->flmap1 >> 24) & 0xff);
: else
: printf(" ISL: 0x%02x\n", (fdb->flmap1 >> 24) & 0xff);
suggestion: use the `is_platform_with_100x_series_pch()` to just print out "PSL" or "ISL", then print the rest separately
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44817
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5141ae5dd174659fde5401fac313a701ae4f8f44
Gerrit-Change-Number: 44817
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 27 Aug 2020 17:19:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment