Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40911 )
Change subject: mb/purism/librem_skl: Convert to use override devicetree ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40911/2/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/variants/librem15v3/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40911/2/src/mainboard/purism/librem... PS2, Line 3: # Enable CLKREQ# for RP9 : register "PcieRpClkReqSupport[8]" = "0" : # ClkReq for NVMe - Bruteforced (no other value works) : register "PcieRpClkReqNumber[8]" = "2" Just noticed, something is fishy here. Comment says enable, but it's disabled. And when it's disabled, there should no need to configure it...