Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Sean Rhodes, Stefan Reinauer.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80883?usp=email )
Change subject: payload/external/edk2: Explicitly define the build arch
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
if this breaks building UniversalPayload for Sean, then perhaps this addition needs to be moved insi […]
The directory indeed seems to be the issue:
```
make[2]: Entering directory '/home/nicholas/Development/coreboot/payloads/external/edk2/workspace/Build/UefiPayloadPkg$(BUILD_ARCH)/RELEASE_COREBOOT/X64/MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib'
GNUmakefile:281: /home/nicholas/Development/coreboot/payloads/external/edk2/workspace/Build/UefiPayloadPkg/RELEASE_COREBOOT/X64/MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib/deps_target: No such file or directory
```
I'm not sure what the `EDK2_PAYLOAD_UEFIPAYLOAD` guard is. Placing it inside a `EDK2_REPO_OFFICIAL` guard seems to work though.
```
ifeq ($(CONFIG_EDK2_REPO_OFFICIAL),y)
BUILD_STR += -D BUILD_ARCH=X64
endif
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80883?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd942d0c15a99231d09f9cbdc5eb48333b6aa6e5
Gerrit-Change-Number: 80883
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 04 Mar 2024 00:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-MessageType: comment