Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45301 )
Change subject: mb/volteer: Add Runtime D3 Support for SSD for Volteer
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Shreesh, I hope you don't mind, but I took the liberty of cleaning this up a bit first so it's easier to see what's going on.
Hi Tim,
That is ok. I have a question. Could you please check the patch - https://review.coreboot.org/c/coreboot/+/43600? Since Pcie.asl file is common between all platforms, I handled using macros and defined macros in respective board's gpio.h file. I cleaned up pmc.asl as well. I was thinking of abandoning this patch (before I knew that you were working on this). How do we proceed?
I'll take a look at yours
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7629e42a14120718ef7b727b76bf80143c226660
Gerrit-Change-Number: 45301
Gerrit-PatchSet: 2
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Sep 2020 17:45:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment