Attention is currently required from: Martin L Roth, Naresh Solanki.
Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/87214?usp=email )
Change subject: src/soc/amd/* : Move CPU init in common code
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
the corresponding change in soc/amd/picasso/cpu.c is missing
File src/soc/amd/cezanne/cpu.c:
https://review.coreboot.org/c/coreboot/+/87214/comment/ad364718_bdf7c7ce?usp... :
PS2, Line 4: #include <amdblocks/mca.h>
: #include <cpu/amd/microcode.h>
those two includes can likely be dropped. same for the other socs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87214?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If53455f359302f368f7c979defa2c1088c5c2f16
Gerrit-Change-Number: 87214
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Wed, 09 Apr 2025 12:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No