build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34980 )
Change subject: southbridge/intel: Tidy up preprocessor and headers ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34980/4/src/southbridge/intel/fsp_r... File src/southbridge/intel/fsp_rangeley/soc.h:
https://review.coreboot.org/c/coreboot/+/34980/4/src/southbridge/intel/fsp_r... PS4, Line 55: void acpi_fill_in_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/34980/4/src/southbridge/intel/fsp_r... PS4, Line 55: void acpi_fill_in_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/34980/4/src/southbridge/intel/fsp_r... PS4, Line 69: int smbus_read_byte(unsigned device, unsigned address); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/34980/4/src/southbridge/intel/fsp_r... PS4, Line 69: int smbus_read_byte(unsigned device, unsigned address); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/34980/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/i82801ix.h:
https://review.coreboot.org/c/coreboot/+/34980/4/src/southbridge/intel/i8280... PS4, Line 217: int smbus_read_byte(unsigned device, unsigned address); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/34980/4/src/southbridge/intel/i8280... PS4, Line 217: int smbus_read_byte(unsigned device, unsigned address); Prefer 'unsigned int' to bare use of 'unsigned'