[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Allow setting PCIe subsystem IDs after FSP Sili...

[Tim Crawford (Code Review)]

Attention is currently required from:  Felix Singer, Jeremy Soller, Angel Pons.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49104 )

Change subject: soc/intel/cannonlake: Allow setting PCIe subsystem IDs after FSP SiliconInit
......................................................................

Patch Set 5:

(2 comments)

File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/49104/comment/71a851c5_0acd13de 
PS4, Line 528: 	/* Disable setting subsystem ID, which causes it to lock */
> I couldn't resolve `it` when parsing this sentence. How about: […]

write-once*. Also added a comment about requiring at least 1 entry.

https://review.coreboot.org/c/coreboot/+/49104/comment/9df8e062_0ab9fe48 
PS4, Line 548: 	const struct svid_ssid_init_entry ssid_table[] = {0};
> Do not allocate this variable on the stack. […]

Done