Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39993 )
Change subject: security/tpm: Fix compile-time elimination for SEPARATE_VERSTAGE
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39993/2/src/security/tpm/tspi/tspi....
File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/c/coreboot/+/39993/2/src/security/tpm/tspi/tspi....
PS2, Line 114: if (CONFIG(VBOOT)) {
Could { return vboot_logic_executed() || verification_should_run() || tpm_is_setup; } give the same result?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc25acf1e6c02d929639e83d529cc14af80e0870
Gerrit-Change-Number: 39993
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 Apr 2020 03:17:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment