Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35269 )
Change subject: soc/amd/common: Add missing stdint.h to lpc.h
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35269/2/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/35269/2/src/soc/amd/common/block/in...
PS2, Line 20: #include <stdint.h>
types.h already include stdint. […]
AFAIK we try to overtly add includes to files using a definition, typedef, etc. vs. relying on them being layered.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35269
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If33765b6dc4236c4b38860bfc4f2cef9b226b81d
Gerrit-Change-Number: 35269
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Sep 2019 16:02:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1002476
Gerrit-MessageType: comment