Attention is currently required from: Paul Menzel.
Ben Chuang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57632 )
Change subject: drivers/genesyslogic/gl9755: Disable ASPM L0s support
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57632/comment/46c2a98b_ce8a323b
PS1, Line 12: TEST=build and check ASPM state
How exactly, and with what device?
The device is GL9755. It is a PCIe to SD card reader. When L0s and L1 are enabled, we measure CLKREQ# is always low, it means the device doesn't enter L1 sub-state. Therefore, we disable L0s so that it can enter L1 sub-state.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57632
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If121b5cb534eb32bac8992683c3f0eee8946acec
Gerrit-Change-Number: 57632
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Chuang
benchuanggli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Greg Tu
greg.tu@genesyslogic.com.tw
Gerrit-CC: HsuanYang Chen
ynop77@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: 陳建宏
renius.chen@genesyslogic.com.tw
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 14 Sep 2021 09:30:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment