cedarhouse1@comcast.net has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38764 )
Change subject: intel/stm: Add platform opt-in Kconfig
......................................................................
Patch Set 1:
Need to also add this to the other Intel processor families Kconfig's as well. Generally, if the processor supports VTX it supports the STM. My oldest platform running an STM is a Sandybridge. And we were working on the family proceeding Sandybridge as well.
Also, I will also all an additional feature MSR (in stm_setup) check that indicates if that particular processor supports an STM. In any case, if the STM setup is not successful, IA32_SMM_MONITOR_VALID does not get set in the IA32_SMM_MONITOR_CTL_MSR.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50f2106ac05c3efb7f92fccb1e6edfbf961b68b8
Gerrit-Change-Number: 38764
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Feb 2020 23:57:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment