Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35320 )
Change subject: soc/fsp_broadwell_de: Move function to get CPUBUSNO(1) into common file ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35320/3/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/35320/3/src/soc/intel/fsp_broadwell... PS3, Line 71: busno1
maybe just call get_busno1() here if there's no need for error checking? That will reduce this code […]
Ack