Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41855 )
Change subject: soc/intel/common: add TCC activation functionality ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41855/5/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/41855/5/src/soc/intel/common/block/... PS5, Line 265: (1 << 30) nit: BIT(30) (#include <types.h> if necessary). could this be a symbolic constant?
https://review.coreboot.org/c/coreboot/+/41855/5/src/soc/intel/common/block/... PS5, Line 274: 0xe6 another symbolic constant?