Attention is currently required from: Paul Menzel, Christian Walter, Angel Pons, Arthur Heymans, Marvin Drees, Patrick Rudolph. Sheng Lean Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61116 )
Change subject: mb/prodrive/atlas: Configure GPIO as per Atlas board ......................................................................
Patch Set 4:
(9 comments)
File src/mainboard/prodrive/atlas/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/61116/comment/639a7de1_bae19e28 PS3, Line 8: static const struct pad_config early_gpio_table[] = {
We probably want to configure the `PCH_HSID` GPIOs (GPP_A8, GPP_F19, GPP_H23, GPP_H19) here, as GPIs […]
Done
https://review.coreboot.org/c/coreboot/+/61116/comment/58fbeea9_737ce8d8 PS3, Line 17: static const struct pad_config early_uart_gpio_table[] = { : /* UART0 RX */ : PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), : /* UART0 TX */ : PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), : /* UART1 RX */ : PAD_CFG_NF(GPP_D17, NONE, DEEP, NF1), : /* UART1 TX */ : PAD_CFG_NF(GPP_D18, NONE, DEEP, NF1), : };
We don't need a separate GPIO table for UARTs, as we always need to configure them.
Done
File src/mainboard/prodrive/atlas/gpio.c:
https://review.coreboot.org/c/coreboot/+/61116/comment/f5ba0300_8707f52a PS3, Line 28: 2
1
Done
https://review.coreboot.org/c/coreboot/+/61116/comment/c1ab9f24_ccccf081 PS3, Line 36: /* ------- GPIO Group GPP_E ------- */
GPP_E3 seems to be used for TPM interrupts, and GPP_E7 seems to be used for EC SMIs. […]
Done. As discussed, will configure E3 later.
https://review.coreboot.org/c/coreboot/+/61116/comment/6dbc8fd0_a8512ec9 PS3, Line 56: NONE
Looks like the pull-down resistor isn't installed, I'd enable a 20K pull-down so that the GPIO doesn […]
Removed it as it is used for strap with internal pull.
https://review.coreboot.org/c/coreboot/+/61116/comment/ae03f005_27e120c3 PS3, Line 58: NONE
Looks like the pull-up resistor isn't installed, I'd enable a 20K pull-up so that the GPIO doesn't f […]
Removed it as it is used for strap with internal pull.
https://review.coreboot.org/c/coreboot/+/61116/comment/efaf89e6_8758aec2 PS3, Line 60: NONE
Looks like the pull-up resistor isn't installed, I'd enable a 20K pull-up so that the GPIO doesn't f […]
Removed it as it is used for strap with internal pull.
https://review.coreboot.org/c/coreboot/+/61116/comment/f6223de5_619ace96 PS3, Line 68: PAD_CFG_GPI(GPP_H0, NONE, DEEP), : PAD_CFG_GPI(GPP_H1, NONE, DEEP), : PAD_CFG_GPI(GPP_H2, NONE, DEEP),
These three GPIOs can be connected to pull-up resistors, but the resistors aren't installed. […]
Removed it as it is used for strap with internal pull.
https://review.coreboot.org/c/coreboot/+/61116/comment/da17aaf9_7654b986 PS3, Line 82: NONE
Looks like the pull-up resistor isn't installed, I'd enable a 20K pull-up so that the GPIO doesn't f […]
Removed it as it is used for strap with internal pull.