mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30749 )
Change subject: sb/amd/agesa/hudson/Kconfig: Disable XHCI by default, enable only with firmware ......................................................................
Patch Set 4:
Patch Set 4:
I'm wondering if you already know if USB3 works at all ( with! ) xhci firmware, on g505s.
Recently my friend Ivan told me that USB3 works at G505S, but only if you 1) change at its' Kconfig from select SOUTHBRIDGE_AMD_AGESA_HUDSON to select SOUTHBRIDGE_AMD_AGESA_BOLTON - because G505S FCH is Bolton-M3, not Hudson 2) and also add the correct xHCI firmware (e.g. available at https://github.com/informer2016/shared_devfiles/blob/master/0.10.0_1022_7814... ) which has been extracted using Felix Held's fch_xhci_rom_dumper - https://github.com/felixheld/fch_xhci_rom_dumper - from G505S while it has been running the proprietary UEFI.
I am really sorry I missed your CR:30899 patch (AGESA/binaryPI: Drop invalid AMD_AGESA_BOLTON) which removed SOUTHBRIDGE_AMD_AGESA_BOLTON and been merged recently :( So I'm not sure if USB3 xHCI will work at the latest coreboot revision because it's not just a different blob but there seems to be a pinout difference between Hudson and Bolton which may affect the results.
I haven't tested by myself but will test at pre-CR:30899 version as soon as possible - and, if USB3 indeed works at G505S if these conditions are satisfied - maybe I would submit a Bolton restoration patch which would be either the same or maybe would be slightly different compared to what CR:30899 has reverted (I will highlight the differences if there would be any). Also, at the same time I could test your CR:21624 patch if it is ready for testing at G505S hardware