[coreboot-gerrit] [S] Change in coreboot[master]: util/amdfwtool: Add preliminary code for morgana & glenda SOCs

[Martin L Roth (Code Review)]

Attention is currently required from: Martin Roth.

Hello Martin Roth,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/68193

to review the following change.

Change subject: util/amdfwtool: Add preliminary code for morgana & glenda SOCs
......................................................................

util/amdfwtool: Add preliminary code for morgana & glenda SOCs

This allows amdfwtool to recognize the names for the upcoming morgana
and glenda SoCs.  It does not yet do anything for those SoCs, but this
allows the morgana SoC to build.

Signed-off-by: Martin Roth 
Change-Id: I766ce4a5863c55cbc4bef074ac5219b498c48c7f
---
M util/amdfwtool/amdfwtool.c
1 file changed, 25 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/68193/1

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index d5b8d92..b56bc8d 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -204,7 +204,7 @@
    printf("                               area\n");
    printf("--soc-name <socname>           Specify SOC name. Supported names are\n");
    printf("                               Stoneyridge, Raven, Picasso, Renoir, Cezanne\n");
-	printf("                               or Lucienne\n");
+	printf("                               Morgana, Glenda, or Lucienne\n");
    printf("\nEmbedded Firmware Structure options used by the PSP:\n");
    printf("--spi-speed <HEX_VAL>          SPI fast speed to place in EFS Table\n");
    printf("                               0x0 66.66Mhz\n");
@@ -625,6 +625,8 @@
    PLATFORM_CEZANNE,
    PLATFORM_MENDOCINO,
    PLATFORM_LUCIENNE,
+	PLATFORM_MORGANA,
+	PLATFORM_GLENDA
 };

static uint32_t get_psp_id(enum platform soc_id)
@@ -1904,6 +1906,10 @@
    		return 1;
    	}
    	break;
+	/* TODO: Update for morgana and glenda */
+	case PLATFORM_MORGANA:
+	case PLATFORM_GLENDA:
+		break;
    case PLATFORM_UNKNOWN:
    default:
    	fprintf(stderr, "Error: Invalid SOC name.\n\n");
@@ -1928,6 +1934,10 @@
    	return PLATFORM_RENOIR;
    else if (!strcasecmp(soc_name, "Lucienne"))
    	return PLATFORM_LUCIENNE;
+	else if (!strcasecmp(soc_name, "Morgana"))
+		return PLATFORM_MORGANA;
+	else if (!strcasecmp(soc_name, "Glenda"))
+		return PLATFORM_GLENDA;
    else
    	return PLATFORM_UNKNOWN;