2 Mar
2022
2 Mar
'22
2:08 a.m.
Attention is currently required from: Jes Klinke, Hung-Te Lin, Patrick Rudolph. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 )
Change subject: i2c: Configurable I2C transfer timeout ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h:
https://review.coreboot.org/c/coreboot/+/62278/comment/2a9bdb2e_a661420d PS7, Line 466: int size, struct stopwatch *timeout); nit: I think just passing the time in microseconds (as an integer) would have been sufficient here...
--
To view, visit https://review.coreboot.org/c/coreboot/+/62278
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6423122f32aad1dbcee0bfe240cdaa8cb512791f
Gerrit-Change-Number: 62278
Gerrit-PatchSet: 7
Gerrit-Owner: Jes Klinke jbk@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jes Klinke jbk@chromium.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 02 Mar 2022 01:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment