Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42133 )
Change subject: device/pnp_ops.h: Use pnp.h functions
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42133/1/src/include/device/pnp_ops....
File src/include/device/pnp_ops.h:
https://review.coreboot.org/c/coreboot/+/42133/1/src/include/device/pnp_ops....
PS1, Line 13: static __always_inline void pnp_write_config(
: pnp_devfn_t dev, uint8_t reg, uint8_t value)
while at it ?: […]
I'd do this on a separate change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c
Gerrit-Change-Number: 42133
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jun 2020 09:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment