Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35466 )
Change subject: drivers/wifi/generic.c: Upper case the AML WiFi name as required by spec ......................................................................
Patch Set 2:
(2 comments)
Patch Set 2:
Patch Set 1:
(2 comments)
OK done
not quite see other comments ;)
https://review.coreboot.org/c/coreboot/+/35466/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35466/2//COMMIT_MSG@9 PS2, Line 9: ACPI specification Version 6.0 (Section 20.2.2 Name Objects Encoding), Again, remove indent on commit msg body.
Something like;
``` The ACPI 6.3; ASL 20.2.2 (Name Objects Encoding), states that;
LeadNameChar := ‘A’-‘Z’ | ‘_’ NameChar := DigitChar | LeadNameChar
Hence, the Intel WiFi names generated in ASL are required to be upper-cased letters. ```
states very precisely what is happening here.
https://review.coreboot.org/c/coreboot/+/35466/2/src/drivers/wifi/generic.c File src/drivers/wifi/generic.c:
https://review.coreboot.org/c/coreboot/+/35466/2/src/drivers/wifi/generic.c@... PS2, Line 242: /* ACPI specification requires uppercase name */ either
/* ACPI 6.3; ASL 20.2.2 (Name Objects Encoding). */
or,
/* ACPI 6.3, ASL 20.2.2: Requires that 'Name' be of the form `0`-`9` | ‘A’-‘Z’ | ‘_’. */
pick one.