Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40558 )
Change subject: soc/intel/common/block/smbus: Set SPD array NULL if no DIMM present
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40558/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/40558/1/src/soc/intel/common/block/...
PS1, Line 43: do_smbus_read_byte(SMBUS_IO_BASE, addr, 0)
What is the value that gets returned by do_smbus_read_byte()? It looks like we should be updating the return type of do_smbus_read_* functions to ensure that we don't have to add these masks every where they are used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40558
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie81adbfab5bb1d5c557fe549a158cb68e26b1162
Gerrit-Change-Number: 40558
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 21 Apr 2020 16:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment