Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49016 )
Change subject: device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49016/3/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/49016/3/src/device/Kconfig@49 PS3, Line 49: config MAINBOARD_HAS_DGPU_VGA_INIT
DGPU doesn't always imply that we need to run a VGA OpROM (we have native coreboot drivers for some discrete chips (e.g. ASpeed), and I hope for DG1 we are able to extend libgfxinit;
I'm also looking for DG enabling using libgfxinit, i'm up for POC.
I have lower hopes for AMD and Nvidia chips).
Maybe name this simply by its intended effect, e.g. `VGA_ROM_RUN_DEFAULT`?
Done
https://review.coreboot.org/c/coreboot/+/49016/3/src/device/Kconfig@64 PS3, Line 64: PAYLOAD_SEABIOS
This is supposed to guard us from a wrong VGA_ROM_RUN default in […]
Ack