View Change
2 comments:
File src/device/Kconfig:
Patch Set #3, Line 49: config MAINBOARD_HAS_DGPU_VGA_INIT
DGPU doesn't always imply that we need to run a VGA OpROM (we have native
coreboot drivers for some discrete chips (e.g. ASpeed), and I hope for
DG1 we are able to extend libgfxinit;
I'm also looking for DG enabling using libgfxinit, i'm up for POC.
I have lower hopes for AMD and Nvidia
chips).
Maybe name this simply by its intended effect, e.g. `VGA_ROM_RUN_DEFAULT`?
Done
Patch Set #3, Line 64: PAYLOAD_SEABIOS
This is supposed to guard us from a wrong VGA_ROM_RUN default in […]
Ack
To view, visit change 49016. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb2fcdb105af449bc20ad727759cdef17d5e376
Gerrit-Change-Number: 49016
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer@chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Tue, 05 Jan 2021 05:46:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment