26 Feb
2025
26 Feb
'25
1:57 a.m.
Attention is currently required from: Alexander Couzens, Alicja Michalska, Angel Pons, Christian Walter, Dinesh Gehlot, Eran Mitrani, Erik van den Bogaert, Felix Held, Frans Hendriks, Fred Reitberger, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jason Glenesk, Jason Nien, Jayvik Desai, Jeremy Soller, Jonathon Hall, Kapil Porwal, Martin L Roth, Martin Roth, Maxim Polyakov, Michael Niewöhner, Michał Kopeć, Michał Żygowski, Nicholas Chin, Nick Vaccaro, Patrick Rudolph, Piotr Król, Pranava Y N, Stefan Ott, Subrata Banik, Tarun, Tim Crawford, Werner Zeh, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/86571?usp=email )
Change subject: tree: Rename CBFS_SIZE to BIOS_SIZE ......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
Patchset:
PS2:
Does CBFS stand for coreboot file system? If so, I think the renaming is more meaningful because `RW […]
A point to clarify is - based on this patch (not the original HEAD), the renaming means BIOS_BASE/SIZE to CB_BASE/SIZE, right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/86571?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I762042fae6357ee368b22a47b8e1168902041675
Gerrit-Change-Number: 86571
Gerrit-PatchSet: 5
Gerrit-Owner: Shuo Liu shuo.liu@intel.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Alicja Michalska ahplka19@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Erik van den Bogaert ebogaert@eltan.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jakub "Kuba" Czapiga czapiga@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai jayvik@google.com
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Jonathon Hall jonathon.hall@puri.sm
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: Pranava Y N pranavayn@google.com
Gerrit-Reviewer: Stefan Ott coreboot@desire.ch
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun tstuli@gmail.com
Gerrit-Reviewer: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-Attention: Stefan Ott coreboot@desire.ch
Gerrit-Attention: Eran Mitrani mitrani@google.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Jakub "Kuba" Czapiga czapiga@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Jonathon Hall jonathon.hall@puri.sm
Gerrit-Attention: Piotr Król piotr.krol@3mdeb.com
Gerrit-Attention: Intel coreboot Reviewers intel_coreboot_reviewers@intel.com
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Pranava Y N pranavayn@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Frans Hendriks fhendriks@eltan.com
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jeremy Soller jeremy@system76.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tarun tstuli@gmail.com
Gerrit-Attention: Erik van den Bogaert ebogaert@eltan.com
Gerrit-Attention: Jayvik Desai jayvik@google.com
Gerrit-Attention: Tim Crawford tcrawford@system76.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Alicja Michalska ahplka19@gmail.com
Gerrit-Attention: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Comment-Date: Wed, 26 Feb 2025 07:57:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: yuchi.chen@intel.com
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Comment-In-Reply-To: Shuo Liu shuo.liu@intel.com