Jonathan Kollasch has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43085 )
Change subject: mb/supermicro/x9scl: Split IPMI support into a variant
......................................................................
Patch Set 1:
Unless we're going to insist that all devices in the device tree be enabled, there is no need for this; the long timeout doesn't happen when the ipmi driver is present but disabled in the device tree.
Additionally, I strongly object to different coreboot variants/builds for boards that are supported by a single platform firmware build from the original board vendor, as is the case with the X9SCL/X9SCL-F/X9SCM/X9SCM-F/X9SCL+-F/X9SCM-II-F (and X9SCL+/X9SCM-II if they ever were made).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cc348135469052c595297226e5e86c040de4746
Gerrit-Change-Number: 43085
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Jul 2020 12:10:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment