[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/acpi: Add provision to inject PCI PIRQ ACPI ma...

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34658 )

Change subject: soc/intel/common/block/acpi: Add provision to inject PCI PIRQ ACPI mapping
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34658/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/34658/5/src/soc/intel/common/block/... 
PS5, Line 242: 
             : 		acpigen_write_scope("\");
             : 		acpigen_write_name("PIRX");
             : 		acpigen_write_package(num_entries);
> I has tried that too, still could see the PIRX reference missing in kernel. […]

Tim , I tried setting the scope to _SB.PCI0 for PIRX and changed the External reference to External(_SB.PCI0.PIRX) and could still see the kernel hang. I had it earlier too, even configuring the return from PRT to _SB.PCI0.PIRX. I then had to follow the same implementation as GNVS.