Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34080 )
Change subject: mb/google/octopus: Add custom SAR values for Bluebird
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34080/2/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/casta/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34080/2/src/mainboard/google/octopu...
PS2, Line 25: google_chromeec_cbi_get_sku_id
now get_board_sku is a global function, it'll be good to use instead of calling google_chromeec_cbi_get_sku_id directly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34080
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I107a8519832fcf906b94f958a3dc508d19bb4727
Gerrit-Change-Number: 34080
Gerrit-PatchSet: 2
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-CC: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Comment-Date: Fri, 05 Jul 2019 06:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment