[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Avoid redundant if condition

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38992 )

Change subject: soc/intel/icelake: Avoid redundant if condition
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38992/1/src/soc/intel/icelake/fsp_p... 
File src/soc/intel/icelake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/38992/1/src/soc/intel/icelake/fsp_p... 
PS1, Line 97: 		params->GtFreqMax = 2;
            : 		params->CdClock = 3;
So, are these two directly related to PeiGraphicsPeimInit (i.e. the GOP
driver)? I can't tell because relations between FSP UPDs are still
undocumented.

If that is the case, please document it. Preferably in FspsUpd.h, but if
that is impossible maybe a comment here?

https://review.coreboot.org/c/coreboot/+/38992/1/src/soc/intel/icelake/fsp_p... 
PS1, Line 102: 		 * in the devicetree.cb.
`or GOP gfx init was disabled in the config`?