HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31917 )
Change subject: soc/intel/cnl: Generate ACPI DMAR table
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31917/1/src/soc/intel/cannonlake/include/soc...
File src/soc/intel/cannonlake/include/soc/systemagent.h:
https://review.coreboot.org/#/c/31917/1/src/soc/intel/cannonlake/include/soc...
PS1, Line 36: 0x5da8
: #define GFXVTBAR 0x5400
: #define EDRAMBAR 0x5408
: #define IPUVTBAR 0x7884
: #define VTVC0BAR 0x5410
: #define REGBAR
maybe use tab ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e1ee5244c67affb13947436d81628c5dc665c9e
Gerrit-Change-Number: 31917
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 16 Mar 2019 06:37:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment