EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41725 )
Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration ......................................................................
soc/intel/tigerlake: Correct GPIO community PID configuration
Current implementation retuns the incorrect GPIO community PID. The GPIO community index 3 should return PID for COMM_4 and index 4 should return PID for COMM_5.
TEST=Verify PCR port id is correct for each community.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5dc48e5b31f43853b3a613c17f13f7df71f1fbfa --- M src/soc/intel/tigerlake/acpi/gpio.asl 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/41725/1
diff --git a/src/soc/intel/tigerlake/acpi/gpio.asl b/src/soc/intel/tigerlake/acpi/gpio.asl index 6206eb7..b17abfe 100644 --- a/src/soc/intel/tigerlake/acpi/gpio.asl +++ b/src/soc/intel/tigerlake/acpi/gpio.asl @@ -106,19 +106,19 @@ { Switch (ToInteger (Arg0)) { - Case (0) { + Case (COMM_0) { Local0 = PID_GPIOCOM0 } - Case (1) { + Case (COMM_1) { Local0 = PID_GPIOCOM1 } - Case (2) { + Case (COMM_2) { Local0 = PID_GPIOCOM2 } - Case (4) { + Case (COMM_4) { Local0 = PID_GPIOCOM4 } - Case (5) { + Case (COMM_5) { Local0 = PID_GPIOCOM5 } Default {