[coreboot-gerrit] Change in coreboot[master]: soc/intel/cnl: Allow enabling/disabling PEG devices

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44741 )

Change subject: soc/intel/cnl: Allow enabling/disabling PEG devices
......................................................................

Patch Set 7:

(1 comment)

Have all the devicetrees been checked that they enable available
PEG ports?

https://review.coreboot.org/c/coreboot/+/44741/7/src/soc/intel/cannonlake/ro... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/44741/7/src/soc/intel/cannonlake/ro... 
PS7, Line 135: #if CONFIG(SOC_INTEL_CANNONLAKE_PCH_H)
Why the preprocessor guard? It's the same FSP headers for PCH-H and SoC, isn't it? If a C-if works, please use that.