David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34400 )
Change subject: mb/google/hatch/var/kindred: Implement variant_devtree_update()
......................................................................
Patch Set 4:
(2 comments)
Thanks.
https://review.coreboot.org/c/coreboot/+/34400/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/34400/3/src/mainboard/google/hatch/...
PS3, Line 20: #define SKU_UNKNOWN 0xFFFFFFFF
Not required.
Done
https://review.coreboot.org/c/coreboot/+/34400/3/src/mainboard/google/hatch/...
PS3, Line 24: SKU_UNKNOWN
Not required anymore. sku_id is set in line 33.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34400
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ccb4dae54f223881e0ced9e034bf45b994cc6f2
Gerrit-Change-Number: 34400
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jul 2019 05:22:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment