Attention is currently required from: Zhi7 Li. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility ......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56930/comment/dde5edf3_301ae84f PS7, Line 2: field AUDIO_CODEC_SOURCE 41 43 Can you please confirm that there are no conflicts with the second source of other components in Sasukette? Please check EC as well.
https://review.coreboot.org/c/coreboot/+/56930/comment/6af8d154_af4856d2 PS7, Line 4: 3 Why is it 3 instead of 2 - i.e. why is there a gap?
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/8fb366e7_7fcd9e71 PS7, Line 29: config->hid = "RTL5682"; Nit: Seems there are 2 spaces between = and "RTL5682"