Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42313 )
Change subject: tests: Add lib/b64_decode-test test case ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c File tests/lib/b64_decode-test.c:
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c... PS1, Line 19: {"SGVsbG8h", "Hello!"} nit: How about adding one with line breaks since the API explicitly supports that?
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c... PS1, Line 27: /* Provide necessary definition in order to satisfy dependencies. */ This is something that many tests will need, so it might be worth factoring out somewhere? We could create something like tests/stubs/console-stub.c and put this in there (and related stuff like do_vprintk()).