[coreboot-gerrit] Change in coreboot[master]: mb/up/squared: rewrite GPIO config using intelp2m

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39765 )

Change subject: mb/up/squared: rewrite GPIO config using intelp2m
......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39765/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39765/3//COMMIT_MSG@17 
PS3, Line 17: [WIP] Please review and test coreboot image with this patch
> So, how about changing the raw values in a commit before rewriting them with macros? It would be eas […]

I have another idea.
I suggest converting raw values to _PAD_CFG_STRUCT() first and then converting _PAD_CFG_STRUCT() to our favorite PAD_CFG_*() macros - 2 patches.

In this case, we can see which fields will be ignored.