Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35524 )
Change subject: mb/supermicro/x11: remove vendor id config
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35524/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35524/1//COMMIT_MSG@9
PS1, Line 9: the default
: value from the PCI Cfg
Sorry, I don't really get what you want me to do...
In one sentence: don't write confusing commit messages.
You could write "Most SSVID registers are filled with 0x8086
(their VID) by default[, anyway]."
I have no idea why that 8086 was there in the Kconfig, btw. It's
best to talk to the authors, I don't know if it serves any purpose.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35524
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If67c679bb342f63096902535734106e4f1651118
Gerrit-Change-Number: 35524
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 22 Sep 2019 13:22:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment