Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )
Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 77: 120 * T3 is >= 10ms in the spec between Reset and Report_EN? * And there is to stop_gpio (report_en) here? * Then stop_delay_ms can be 110ms
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 78: 3 1ms for T2 and T3 in the spec so do we play safe here?
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 80: 12 The GT7375P Programming Guide Rev 0.4 mentions that T1 (AVDD -> Reset) is >= 10 so we set to 12 for playing safe?