Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36685 )
Change subject: src/mb/intel/coffeelake_rvp: Add mainboard for CML-S RVP8 ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36685/10/src/mainboard/intel/coffee... File src/mainboard/intel/coffeelake_rvp/variants/cml_s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36685/10/src/mainboard/intel/coffee... PS10, Line 73: register "PcieRpEnable[0]" = "0"
will revise it
Done
https://review.coreboot.org/c/coreboot/+/36685/10/src/mainboard/intel/coffee... PS10, Line 91: register "PcieRpEnable[4]" = "1"
will add a comment
Done
https://review.coreboot.org/c/coreboot/+/36685/10/src/mainboard/intel/coffee... PS10, Line 151: Tunderbolt
Thanks. Good catch.
Done