[coreboot-gerrit] Change in coreboot[master]: payloads/seabios: Add Hardware IRQ Kconfig

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39869 )

Change subject: payloads/seabios: Add Hardware IRQ Kconfig
......................................................................

payloads/seabios: Add Hardware IRQ Kconfig

Certain boards require SeaBIOS' HARDWARE_IRQ option to be
deselected in order for the platform to boot. Add a Kconfig
to allow selection of HARDWARE_IRQ enablement, and write to
SeaBIOS' .config file in cases where it needs to be disabled.
Deselect the option for google/rambi variants so they boot
with boards defaults.

Test: build/boot google/clapper, verify board boots vs hanging
at boot menu prompt.

Change-Id: I23e9b30d2d1042c86bd10f134d6fe361edaf8cb2
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39869
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
---
M payloads/external/SeaBIOS/Kconfig
M payloads/external/SeaBIOS/Makefile
M src/mainboard/google/rambi/Kconfig
3 files changed, 18 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/payloads/external/SeaBIOS/Kconfig b/payloads/external/SeaBIOS/Kconfig
index e816775..21e4720 100644
--- a/payloads/external/SeaBIOS/Kconfig
+++ b/payloads/external/SeaBIOS/Kconfig
@@ -51,6 +51,16 @@
      variations during option ROM code execution. It is not
      known if all option ROMs will behave properly with this option.

+config SEABIOS_HARDWARE_IRQ
+	prompt "Hardware Interrupts"
+	default y
+	bool
+	help
+	  Program and support hardware interrupts using the i8259
+	  programmable interrupt controller (PIC).  Deselected by
+	  boards which would otherwise hang at the boot menu (eg,
+	  google/rambi).
+
 config SEABIOS_VGA_COREBOOT
    prompt "Include generated option rom that implements legacy VGA BIOS compatibility"
    default y if !VENDOR_EMULATION
diff --git a/payloads/external/SeaBIOS/Makefile b/payloads/external/SeaBIOS/Makefile
index 0086775..cd646d9 100644
--- a/payloads/external/SeaBIOS/Makefile
+++ b/payloads/external/SeaBIOS/Makefile
@@ -72,6 +72,9 @@
 ifneq ($(CONFIG_SEABIOS_DEBUG_LEVEL),-1)
    echo "CONFIG_DEBUG_LEVEL=$(CONFIG_SEABIOS_DEBUG_LEVEL)" >> seabios/.config
 endif
+ifneq ($(CONFIG_SEABIOS_HARDWARE_IRQ),y)
+	echo "# CONFIG_HARDWARE_IRQ is not set" >> seabios/.config
+endif
 #	This shows how to force a previously set .config option *off*
 #	echo "# CONFIG_SMBIOS is not set" >> seabios/.config
    $(MAKE) -C seabios olddefconfig OUT=out/
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig
index bc4aa6e..3cb5e26 100644
--- a/src/mainboard/google/rambi/Kconfig
+++ b/src/mainboard/google/rambi/Kconfig
@@ -77,6 +77,11 @@
    default "GOOGLE"

config CONSOLE_SERIAL
+	bool
+	default n
+
+config SEABIOS_HARDWARE_IRQ
+	bool
    default n

endif # BOARD_GOOGLE_BASEBOARD_RAMBI