Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf...
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf...
PS4, Line 12: #ifndef CONFIG_DPTF_CPU_ADDR
: CONFIG_DPTF_CPU_ADDR = 0x00040000ul,
: #endif
Given that this enum is defined for Participant Type, can we keep the address outside?
This is the default for DPTF, for all SoCs I've seen except the Core line (APL, etc.) which seem to use 0x1. I don't think it needs to be exported from here, only this module should need to use the address.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief69a57adce9ee0b19056ce6a11ed8a5b51b3f87
Gerrit-Change-Number: 41884
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 16:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment