Attention is currently required from: Name of user not set #1002003, Paul Menzel, John Zhao, Rajmohan Mani.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63848 )
Change subject: drivers/intel/usb4: Add Type-C port device attachment check
......................................................................
Patch Set 8:
(1 comment)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/63848/comment/ca865a21_4d8f9ffa
PS8, Line 71: acpigen_disable_tx_gpio(power_gpio);
This GPIO was already disabled on line 40, and I don't see anything different happening to it since then, does it need to be disabled again?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63848
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5392d0d3a947dbf172cadfe03fc708f6e2e87210
Gerrit-Change-Number: 63848
Gerrit-PatchSet: 8
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Name of user not set #1002003
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Zhao
jzhao80@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Name of user not set #1002003
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Comment-Date: Tue, 03 May 2022 20:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment