Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )
Change subject: Fix for missing mem_rank info in SMBIOS
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31235/1/src/soc/intel/common/smbios.h
File src/soc/intel/common/smbios.h:
https://review.coreboot.org/#/c/31235/1/src/soc/intel/common/smbios.h@24
PS1, Line 24: u32 frequency, u8 rank_per_dim, u8 channel_id, u8 dimm_id,
prototype doesn't match implementation
https://review.coreboot.org/#/c/31235/1/src/soc/intel/common/smbios.c
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/#/c/31235/1/src/soc/intel/common/smbios.c@23
PS1, Line 23: u32 frequency, u8 rankInDimm, u8 channel_id, u8 dimm_id,
please don't use camel case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I212215040e4786c258a9c604cc5c2bb62867c842
Gerrit-Change-Number: 31235
Gerrit-PatchSet: 1
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 05 Feb 2019 08:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment