Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42523 )
Change subject: [WIP] soc/amd/common: Place guards for ACPIMMIO on ENV_ARM ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42523/7/src/soc/amd/picasso/i2c.c@5... PS7, Line 55: switch (dev->path.mmio.addr) { If we continue with the ideological view that no x86 memory space symbols should appear in ARCH_VERSTAGE_ARMxx environment, what is the plan on these MMIO device addresses. To get past this for amd/picasso I think this ENV_X86 guard here would be option than splitting the file.
IMHO there is something else fundamentally wrong when we do this reverse-mapping from MMIO address to device node names. If there is better solution for this, the x86-centric identifiers APU_I2Cx_BASE might just disappear here.