Attention is currently required from: Jason Nien, Martin Roth.
Hello Jason Nien, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73441
to look at the new patch set (#2).
Change subject: mb/google/skyrim: override winterhold & whiterun PCIe config ......................................................................
mb/google/skyrim: override winterhold & whiterun PCIe config
Winterhold & Whiterun boards populate either NVMe or eMMC, but not both. This means that there is always one link that is unpopulated. The PCIe configuration code takes longer to verify that a link is unpopulated than to just train the link, so this slows down the boot by roughly 80ms vs the case when the device is present. Not training the device at all lowers boot time by another 20ms, for a total of 100ms saved.
Looking at the NVMe CLKREQ signal before initializing the ports allows us to identify which device is populated and only initialize that device.
BUG=b:271569628 TEST=Boot Whiterun and eMMC or NVMe correctly work, boot time is lower.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: I0b87f5e968cd1c87e62a1c0fbdee1fc0723f655d --- M src/mainboard/google/skyrim/variants/whiterun/Makefile.inc A src/mainboard/google/skyrim/variants/whiterun/port_descriptors.c M src/mainboard/google/skyrim/variants/winterhold/Makefile.inc A src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c 4 files changed, 256 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/73441/2