EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35175 )
Change subject: mb/google/drallion: Update gpio config for drallion ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli... PS6, Line 36: /* SUSWARN# */ PAD_NC(GPP_A13, NONE), We may this for SD card reader D3 cold. Could you chech with Tim?
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli... PS6, Line 38: /* SUSACK# */ PAD_NC(GPP_A15, NONE), We may this for SD card reader D3 cold. Could you chech with Tim?
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli... PS6, Line 91: /* UART0_RTS# */ PAD_CFG_GPI(GPP_C10, NONE, PLTRST), This should be GPO, WWAN_FULL_PWR_EN default high.
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli... PS6, Line 103: /* UART2_RTS# */ PAD_CFG_GPI(GPP_C22, NONE, PLTRST), /* SPK detect */
https://review.coreboot.org/c/coreboot/+/35175/6/src/mainboard/google/dralli... PS6, Line 157: /* DDPE_HPD3 */ PAD_NC(GPP_E16, NONE), HDMI_PD#, GPO default high