[coreboot-gerrit] Change in ...coreboot[master]: mainboard/{google,intel}: Remove SaGv hard coding

[Ronak Kanabar (Code Review)]

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31120 )

Change subject: mainboard/{google,intel}: Remove SaGv hard coding
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31120/2/src/mainboard/intel/cannonlake_rvp/v... 
File src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb:

https://review.coreboot.org/#/c/31120/2/src/mainboard/intel/cannonlake_rvp/v... 
PS2, Line 8: SaGv_FixedHigh
> Yes, I think it should be 4 for this case, SaGV_Enabled.

For CNL FSP 3 means FixedHigh. It was set 3 previously so I made it fixedhigh. I am not sure why it was configured 3 previously. I was removing fixed value and replacing with SaGv macro so configured as FixedHigh.

CNL FSP SaGv configation options are as follow.
0:Disabled, 1:FixedLow, 2:FixedMid, 3:FixedHigh, 4:Enabled

You can also refer to macro in following file
https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/cannonlake/...

I need to check previously why it was configured it to 3. so for this patch we can use this value. If it ok to configure it to SaGv_Enable I will push patch for that.