Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46658 )
Change subject: soc/intel/xeon_sp: Use common cpu/intel romstage entry
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46658/6/src/soc/intel/xeon_sp/memma...
File src/soc/intel/xeon_sp/memmap.c:
https://review.coreboot.org/c/coreboot/+/46658/6/src/soc/intel/xeon_sp/memma...
PS6, Line 37: cbmem_top
I guess FSP provides this pointer? On SKL and CFL, the value for this pointer is MTRR poison (trying […]
I don't recall seeing bad things on that. The behaviour is not changed in this patch so it can be tackled later on if it proves to be a problem.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie85df5d244fa37c41f0b3177ca325c607fa54593
Gerrit-Change-Number: 46658
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 28 Oct 2020 17:15:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment