Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: [WIP] soc/amd/common: Access ACPI MMIO via proper symbols
......................................................................
Patch Set 5:
Patch Set 5:
(2 comments)
Only downside to this is that we're doing and extra read for every access to the bank instead of constants in the instruction stream.
Is it a downside? These sequences often do read-modify-writes so the address will appear multiple times in the instruction stream vs loading the base once into a register and using relative offseting. Depends of course of the arch how well it works but constants are not choice for PSP here anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37324
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8599ee93bfb1c2d6d9b4accfca1ebbefe758e09
Gerrit-Change-Number: 37324
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jun 2020 14:27:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment