Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31161 )
Change subject: acpi: device: avoid empty property list in acpi_dp_write ......................................................................
Patch Set 1:
Does IASL or FWTS complain about that?
The errors reported by FWTS (tested against the entire WIP commit chain) appear to be unrelated:
_SB_.PCI0.I2C4.MAXR._HID returned a string 'MX98373' but it was not a valid PNP ID or a valid ACPI ID. _SB_.PCI0.I2C4.MAXL._HID returned a string 'MX98373' but it was not a valid PNP ID or a valid ACPI ID. _SB_.PCI0.XHCI._PS0 returned values, but was expected to return nothing. Object returned: INTEGER: 0x00000000 _SB_.PCI0.XHCI._PS3 returned values, but was expected to return nothing. Object returned: INTEGER: 0x00000000 _SB_.PCI0.B0D4._PTC should contain only Resource Descriptors _SB_.PCI0.B0D4._TSD sub-package 0 element 3 (CoordType) was expected to have value 0xfc (SW_ALL), 0xfd (SW_ANY) or 0xfe (HW_ALL), instead it was 0x0. _SB_.PCI0.B0D4._TSS sub-package 0 element 0 was expected to have value 1..100, instead was 0. MCFG MMIO config space at 0xe0000000 is not reserved in the memory map table DBG2 Generic Address Structure has zero register bit width which is probably incorrect