Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34705 )
Change subject: mb/google/helios: Set SPKR_PA_EN PIN high for boot beep
......................................................................
Patch Set 1:
Patch Set 1:
Does it need to be enabled in coreboot or can the bootloader apply it?
I guess you mean to say "depthchage" when you are referring "can the bootloader apply it?"
yes, DC can also do it and i don't believe it has my given timing sequence that SPKR_EN has to be enable "n" ms before sending i2C data and clock. Although we haven't tried moving that code into payload, i'm not big fan of doing GPIO programming in payload :), but certainly can be verified before sending init sequence to codec.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34705
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I012462f93e9e2bcafe5f18ce7d04e3fcd1db9ffa
Gerrit-Change-Number: 34705
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Aug 2019 16:08:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment